SNOW-2184600: reduce binary size by opt-out arrow-go/compute package #1459
+1,519
−732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
Hi @sfc-gh-dszmolka , Could you review this PR? |
Contributor
|
hi @datdao thank you for this PR ! unfortunately i'm not code owner here, but the dev team will review. |
Author
|
Hi @sfc-gh-dszmolka, @sfc-gh-pfus , Could you please review my PR? |
Contributor
|
hello @datdao as mentioned in my previous comment, i'm not a code owner here, so i'm really unable to review the PR. |
Collaborator
|
Hi @datdao , sorry for keeping you waiting. We are busy in our team now and your PR is a big one. I need to find some free time to understand your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue: #1455
This pull request introduces a restructuring of the Snowflake Go driver to better handle Arrow data processing by separating batch-related functionality into dedicated files. The changes aim to improve modularity and maintainability while addressing the distinction between batch and non-batch builds.