Feature: Reimplement mnemonic validation #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of this branch is to introduce a proper method of validating mnemonics, discarded in previous versions. List of changes: - updated mnemonic.dart with a new isValidMnemonic() method of validating mnemonics without creating a Mnemonic object. Previously implemented validation in Mnemonic object constructor has been updated to work with the converted static methods but otherwise remained unchanged as it might later be used for displaying more specific reasons on why a mnemonic is invalid. - updated mnemonic_test.dart to include tests for the new isValidMnemonic() method
dpajak99
approved these changes
Mar 18, 2025
kronikarz
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this branch is to introduce a proper method of validating mnemonics, discarded in previous versions.
List of changes: