Initial Catalog Collection Remote Tests #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpparts
changed the title
snbianco
reviewed
Dec 24, 2025
Owner
snbianco
left a comment
snbianco
left a comment
There was a problem hiding this comment.
Hey Celia! This is great work; thank you so much again for helping out with this. I left some comments, but let me know if you have questions. And it goes without saying, but please don't feel the need to apply any of these until after the holidays!
cpparts
force-pushed
the
catalog_collection_remote_tests
branch
from
e9a9103 to
1e749b9
Compare
snbianco
reviewed
Jan 8, 2026
Owner
snbianco
left a comment
snbianco
left a comment
There was a problem hiding this comment.
This is really great progress! The main thing I noticed is that this particular set of tests takes quite a bit to run. I left some comments with ideas for how to speed things up. You can tell which tests took the most amount of time by using --durations=0 as an argument to your pytest command.
Owner
|
I'm also going to work on some code changes that should help to speed things up! |
cpparts
force-pushed
the
catalog_collection_remote_tests
branch
from
10a7b56 to
e19e92b
Compare
snbianco
reviewed
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first pass at remote tests for the CatalogCollection! Coverage was 95% for catalog_collection.py with these.
Happy to make any changes, and looking forward to suggestions/feedback!