Skip to content
This repository was archived by the owner on Oct 10, 2025. It is now read-only.

Conversation

@frenchwr
Copy link
Member

The primary change here is to switch from installing stable diffusion models at ~/openvino-ai-plugins-gimp to a hidden directory at ~/.local/share/openvino-ai-plugins-gimp. This requires adding the personal-files interface to the new snap (which will likely trigger a manual review of the gimp snap as it did for the openvino-ai-plugins-gimp snap). See this forum post for more discussion.

Other changes:

  • Remove manual interface connections for openvino-ai-plugins-gimp snap as those now autoconnect 🥳
  • Switch to main branch for fetching command-chain script

@frenchwr
Copy link
Member Author

The build is failing because of the new interface:

Errors
------
 - declaration-snap-v2:plugs_installation:dot-local-share-openvino-ai-plugins-gimp:personal-files
	human review required due to 'allow-installation' constraint (bool)
gimp_2.99.16_amd64.snap: FAIL

I will reach out to the store team to request a review and then we can re-run.

@jnsgruk
Copy link
Member

jnsgruk commented Dec 19, 2024

Hey, you can update the declarations to unblock the build like this: https://github.com/snapcrafters/gimp/blob/candidate/.github/slot-declaration.json

@frenchwr
Copy link
Member Author

Hey, you can update the declarations to unblock the build like this: https://github.com/snapcrafters/gimp/blob/candidate/.github/slot-declaration.json

Added a plot-declaration.json and that fixed the build - thanks!

jnsgruk
jnsgruk previously approved these changes Dec 19, 2024
Copy link
Member

@jnsgruk jnsgruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change, then we're good to merge. Thanks!

@jnsgruk jnsgruk merged commit b0271b7 into snapcrafters:2.99-openvino Dec 19, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants