Only use the __CWCC__ macro to test for cwcc
#295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KooShnoo
force-pushed
the
cwcc_macro
branch
2 times, most recently
from
e4db51f to
b4b78bc
Compare
em-eight
reviewed
Jun 5, 2025
lib/MSL/include/stdlib.h
Outdated
| #define labs(x) (x) | ||
| #else | ||
| #error compiler has no instrinsic abs support, please do some sit ups. | ||
| #error "attempted to compile MSL (Metrowerks Standard Library) header with non-codewarrior compiler" |
Contributor
There was a problem hiding this comment.
- It doesn't seem bad to me to allow compiling MSL with non-CWCC. Desktop builds could just link with different source files if they do not want MSL.
- The way this is implemented doesn't stop this from happening anyway, it would need to be an include in all MSL headers
Contributor
Author
There was a problem hiding this comment.
Yeah im not sure what to do for non-MW support in general, beacuse feel free to suggest what you want. maybe even set a guidline and put it in contributing.md?
also, i enable "Allow edits by maintainers" btw, so you should be able to add to my PRs if you want to. I also added you to my fork so u can force push as well.
Contributor
There was a problem hiding this comment.
I'd say just ignore that case for now. Most likely non MSL builds will just skip having it in its include paths and no link with it in the first place. If they want some part of it for some reason, their trouble
Contributor
Author
|
narrowed scope to remove clangd macro stuff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.