Skip to content

Add Github Actions for test-build #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yqs112358 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Github Actions for test-build #60

yqs112358 wants to merge 2 commits into from

Conversation

@yqs112358
Copy link

@yqs112358 yqs112358 commented Dec 31, 2025 •
edited
Loading

  • Make test-builds in GitHub Actions after push to main branch. Build each version in parallel.
  • Upload build artifacts, so users can download the builds for testing in advance.

@yqs112358
Copy link
Author

yqs112358 commented Dec 31, 2025

I have tested the github action's build of TT20 1.21.11, and it works well on my server with many people online at the same time.

@Lemonnik6484 Lemonnik6484 requested a review from JXSnack December 31, 2025 20:49
@Lemonnik6484
Copy link
Collaborator

Lemonnik6484 commented Dec 31, 2025

From what I can see workflow file is good, the only thing that should be changed is final artifact name. It should be in the format tt20-<version>+mc<mcVersion>.jar.
Anyways Snack must decide if we'll publish new builds here

Lemonnik6484
Lemonnik6484 requested changes Dec 31, 2025
View reviewed changes
Copy link
Collaborator

@Lemonnik6484 Lemonnik6484 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Artifact name should be in tt20-<modVersion>+mc<mcVersion> format

@Lemonnik6484
Copy link
Collaborator

Lemonnik6484 commented Dec 31, 2025

Anyways, here's my review :3

@yqs112358
Copy link
Author

yqs112358 commented Jan 1, 2026

Okay, changed as your requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lemonnik6484 Lemonnik6484 Lemonnik6484 requested changes

@JXSnack JXSnack Awaiting requested review from JXSnack

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yqs112358 @Lemonnik6484