Draft
Conversation
Brechtpd
reviewed
May 25, 2023
Brechtpd
left a comment
Brechtpd
left a comment
There was a problem hiding this comment.
This looks great! Only a couple of different cases that need to be handled, and those cases are mostly kept very simple with the lookup tables or straightforward with simple constraints.
I think some of the constraints (I went over some pretty quickly for now, so I certainly haven't checked if they are all correct/sufficient) like the rlp_tag_length_cur ones will look very readable when switching to the circuit tools as well.
1. split error types 2. add invalid and error binding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.