Skip to content

Refactoring for LoginBBSActivity.java #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0000foxx wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactoring for LoginBBSActivity.java #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 52 additions & 52 deletions src/net/newsmth/smth/LoginBBSActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,47 +19,47 @@
public class LoginBBSActivity extends AppActivity {

//private
private String last_changelog;
private int notify_number;
private String notify_msg;
private String mLastChangelog;
private int mNotifyNumber;
private String mNotifyMessage;

private String newversion;
private String mNewVersion;

private int ret_newversion;
private int ret_pwd;
private int mRetNewVersion;
private int mRetPwd;

private String m_strUser;
private String m_strPwd;
private String mStrUser;
private String mStrPwd;

//android only
private EditText m_txtFldUser;
private EditText m_txtFldPwd;
private Activity this_activity;
private EditText mTxtFldUser;
private EditText mTxtFldPwd;
private Activity mActivity;

@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_login_bbs);

//android only
m_txtFldUser = (EditText) findViewById(R.id.m_txtFldUser);
m_txtFldPwd = (EditText) findViewById(R.id.m_txtFldPwd);
mTxtFldUser = (EditText) findViewById(R.id.m_txtFldUser);
mTxtFldPwd = (EditText) findViewById(R.id.m_txtFldPwd);

String username = appSetting.getLoginInfoUsr();
String password = appSetting.getLoginInfoPwd();
String userName = appSetting.getLoginInfoUsr();
String passWord = appSetting.getLoginInfoPwd();

if(username!=null && password!=null && !username.equals("") && !password.equals("")){
m_txtFldUser.setText(username);
m_txtFldPwd.setText(password);
if(userName!=null && passWord!=null && !userName.equals("") && !passWord.equals("")){
mTxtFldUser.setText(userName);
mTxtFldPwd.setText(passWord);
}

this_activity = this;
mActivity = this;
LinearLayout screen = (LinearLayout) findViewById(R.id.loginbbsView);
screen.setOnClickListener(new OnClickListener() {
@Override
public void onClick(View v) {
if (v.getId() == R.id.loginbbsView) {
InputMethodManager imm = (InputMethodManager)this_activity.getSystemService(Context.INPUT_METHOD_SERVICE);
InputMethodManager imm = (InputMethodManager)mActivity.getSystemService(Context.INPUT_METHOD_SERVICE);
imm.hideSoftInputFromWindow(v.getWindowToken(), 0);
}
}
Expand All @@ -75,8 +75,8 @@ public boolean onCreateOptionsMenu(Menu menu) {
}

public void pressBtnClear(View v){
m_txtFldUser.setText("");
m_txtFldPwd.setText("");
mTxtFldUser.setText("");
mTxtFldPwd.setText("");

appSetting.setLoginInfo("", "");
}
Expand Down Expand Up @@ -111,10 +111,10 @@ public int checkVersion()
int min_major = dict.optInt("min_major");
int min_minor = dict.optInt("min_minor");
int min_rc = dict.optInt("min_rc");
last_changelog = dict.optString("latest_changelog");
mLastChangelog = dict.optString("latest_changelog");

notify_number = dict.optInt("notify_number");
notify_msg = dict.optString("notify_msg");
mNotifyNumber = dict.optInt("notify_number");
mNotifyMessage = dict.optString("notify_msg");

//app version
String appVer = NSAppSetting.appVer;
Expand All @@ -130,7 +130,7 @@ public int checkVersion()

if((cur_major < latest_major) || (cur_major == latest_major && cur_minor < latest_minor) || (cur_major == latest_major && cur_minor == latest_minor && cur_rc < latest_rc)){

newversion = "" + latest_major + "." + latest_minor + "." + latest_rc;
mNewVersion = "" + latest_major + "." + latest_minor + "." + latest_rc;
return 2;
}
return 1;
Expand All @@ -140,40 +140,40 @@ public int checkVersion()

private boolean checkInputText()
{
if(m_strUser.length() == 0){
ret_newversion = -3;
if(mStrUser.length() == 0){
mRetNewVersion = -3;
return false;
}
if(m_strPwd.length() == 0){
ret_newversion = -4;
if(mStrPwd.length() == 0){
mRetNewVersion = -4;
return false;
}
return true;
}

@Override
public void parseContent(){
ret_newversion = 0;
ret_pwd = 0;
mRetNewVersion = 0;
mRetPwd = 0;

m_strUser = m_txtFldUser.getText().toString();
m_strPwd = m_txtFldPwd.getText().toString();
mStrUser = mTxtFldUser.getText().toString();
mStrPwd = mTxtFldPwd.getText().toString();

if(!checkInputText()){
//different with iOS, don't do dialog in this thread.
m_bLoadRes = 1;
return;
}

notify_number = 0;
mNotifyNumber = 0;
net_ops = 2;

ret_newversion = checkVersion();
if(ret_newversion > 0){
ret_pwd = net_smth.net_LoginBBS(m_strUser, m_strPwd);
mRetNewVersion = checkVersion();
if(mRetNewVersion > 0){
mRetPwd = net_smth.net_LoginBBS(mStrUser, mStrPwd);
}

Log.d("SMTH", "login ret:" + ret_newversion + ret_pwd);
Log.d("SMTH", "login ret:" + mRetNewVersion + mRetPwd);
m_bLoadRes = 1;
}

Expand All @@ -183,8 +183,8 @@ private void goContentView(){
}

private void show_notification(){
if(notify_number > NSAppSetting.my_notify_number){
new AlertDialog.Builder(this).setTitle("通知").setMessage(notify_msg)
if(mNotifyNumber > NSAppSetting.my_notify_number){
new AlertDialog.Builder(this).setTitle("通知").setMessage(mNotifyMessage)
.setPositiveButton("继续提示此条通知", new DialogInterface.OnClickListener() {
@Override
public void onClick(DialogInterface dialog,
Expand All @@ -195,8 +195,8 @@ public void onClick(DialogInterface dialog,
@Override
public void onClick(DialogInterface dialog,
int which) {
NSAppSetting.my_notify_number = notify_number;
appSetting.appSettingChange("my_notify_number", String.valueOf(notify_number));
NSAppSetting.my_notify_number = mNotifyNumber;
appSetting.appSettingChange("my_notify_number", String.valueOf(mNotifyNumber));

goContentView();
}
Expand All @@ -208,8 +208,8 @@ public void onClick(DialogInterface dialog,
}

private void show_newversion(){
if(ret_newversion == 2){
new AlertDialog.Builder(this).setTitle("应用有更新版本，建议升级").setMessage(last_changelog)
if(mRetNewVersion == 2){
new AlertDialog.Builder(this).setTitle("应用有更新版本，建议升级").setMessage(mLastChangelog)
.setPositiveButton("继续提示此版本", new DialogInterface.OnClickListener() {
@Override
public void onClick(DialogInterface dialog,
Expand All @@ -220,8 +220,8 @@ public void onClick(DialogInterface dialog,
@Override
public void onClick(DialogInterface dialog,
int which) {
NSAppSetting.my_dismiss_version = newversion;
appSetting.appSettingChange("dismiss_version", newversion);
NSAppSetting.my_dismiss_version = mNewVersion;
appSetting.appSettingChange("dismiss_version", mNewVersion);

show_notification();
}
Expand All @@ -234,20 +234,20 @@ public void onClick(DialogInterface dialog,

@Override
public void updateContent(){
if(ret_newversion == -2){
if(mRetNewVersion == -2){
new AlertDialog.Builder(this).setTitle("应用版本太低，请升级后重试")
.setPositiveButton("确定",null).setCancelable(false).create()
.show();
}else if(ret_newversion == -3){
}else if(mRetNewVersion == -3){
new AlertDialog.Builder(this).setTitle("账号为空，请输入.")
.setPositiveButton("确定",null).setCancelable(false).create()
.show();
}else if(ret_newversion == -4){
}else if(mRetNewVersion == -4){
new AlertDialog.Builder(this).setTitle("密码为空，请输入.")
.setPositiveButton("确定",null).setCancelable(false).create()
.show();
}else if(ret_newversion > 0 && ret_pwd > 0){
appSetting.setLoginInfo(m_strUser, m_strPwd);
}else if(mRetNewVersion > 0 && mRetPwd > 0){
appSetting.setLoginInfo(mStrUser, mStrPwd);

//TODO: load friends list background

Expand Down