Make ECDSA signature verification customizable

[tomaka]

Close #2016

This adds a new variant to the runtime-call-enums, which this time concerns ECDSA signatures verification.
It works exactly the same way as SignatureVerification, except that you have to provide a public key on success. The possible errors are also more details than just "success" or "failure".

I went with panicking if the public key provided by the API user is invalid. This only concerns the case when resume instead of verify_and_resume is called. I don't want to expose the private types of libsecp256k1, and adding yet another type for parsing the public key seems cumbersome.

I haven't tested this code because I don't think that this is used in any of the relay chains, and I also don't know which parachain uses it and how to easily test this.
However, assuming that the code worked before (which isn't 100% sure for the same reasons), it should still work as the changes were pretty straight forward.

Work time: 1h

[tomaka]

cc @xlc @ermalkaleci

[ermalkaleci]

@xlc I am not if we can utilize this since when you do the mocking we have only the address and not the public key

[ermalkaleci]

@tomaka is this public key passed on resume verified or I can just pass some dummy data?

[ermalkaleci]

@tomaka I tried but got unreachable at this line

message_ptr: expect_pointer_constant_size_raw!(1, 32),
message_size: 32,

seems to fix the panic

[ermalkaleci]

although I still don't know how we can create a mocked signature with valid public

[tomaka]

is this public key passed on resume verified or I can just pass some dummy data?

The public key needs to be a valid ECDSA public key, but it is not checked against the signature.
The problem here is that there are 4 host functions, 2 of which return the public key in raw format and 2 return the public key in compressed format. So what I did is in the public API you're supposed to pass a raw public key, and it gets converted to a compressed one if relevant. But for that to work, the public key has to be valid, it's not just passing it through to the Wasm code.
I can of course adjust the public API if necessary, I'm just trying to find a right balance of flexible but not too cumbersome to use.

[xlc]

@ermalkaleci the idea is to embed a valid public key in the signature and we can just read and return it

[ermalkaleci]

@ermalkaleci the idea is to embed a valid public key in the signature and we can just read and return it

Yes but we have only the address, not public key.

[xlc]

it is possible to get public key from a valid signature so for most of the use cases, we can find signature from old tx and use it to get public key. so mocking wouldn’t work for address never signed a tx but that’s fine. it also means automatic mock would be a bit complicated. maybe we require user to supply a valid signature

[ermalkaleci]

Yes that's my point.

[albertov19]

Hey! My understanding is that this will end up fixing this other Issue right? AcalaNetwork/chopsticks#845

What is the status :) Thanks !