Add download_email method #123
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thank you for reviewing this pull request!
I recently started to use this package in a project and noticed a few things that would really improve it even more.
I'm submitting them in separate pull requests.
There is already an implementation for the download of emailbodyparts.
One can also download email blobs from a JMAP server in a similar way.
I added a download_email to the Client class that takes an Email instance as argument and formats the download_url using its blob_id to stream the raw email from the server. Its completely analogous to download_attachment.
Test for all code additions were added.
I checked that the download actually works with the installed package and a local stalwart emailserver.
All tests and lints passed on the last commit.
There was no AI involved in writing this code.