Fix TypeError with UUID primary keys in issubclass check#992
Open
S3wnkin wants to merge 2 commits intosmithyhq:mainfrom
Open
Fix TypeError with UUID primary keys in issubclass check#992S3wnkin wants to merge 2 commits intosmithyhq:mainfrom
S3wnkin wants to merge 2 commits intosmithyhq:mainfrom
Conversation
- Add inspect.isclass() guard before issubclass() call - Prevents TypeError when column.python_type returns type annotations - Fixes smithyhq#981
aminalaee
reviewed
Feb 4, 2026
Collaborator
aminalaee
left a comment
aminalaee
left a comment
There was a problem hiding this comment.
Can you please add a minimal test to maek sure it works as expected?
2 tasks
Member
|
@S3wnkin any updates on tests? |
aminalaee
added
the
waiting-for-feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add inspect.isclass() guard before issubclass() call
Prevents TypeError when column.python_type returns type annotations
Fixes Regression: TypeError with UUID primary keys in 0.22.0: issubclass() arg 1 must be a class #981