Fix fastapi root path o2m m2m search

[bikmetle]

fix the search in one-to-many or many-to-many field if fastapi root_path is set

app = FastAPI(
root_path="/api",
)

[aminalaee]

Should we do urljoin to make sure starting/ending slashes or joined properly?

[bikmetle]

maybe

    if hasattr(self.app, "root_path"):
        parts = [p.strip("/") for p in [self.app.root_path, base_url] if p.strip("/")]
        self.base_url = "/" + "/".join(parts)

[bikmetle]

or better

self.base_url=urljoin(app.root_path+"/", base_url.lstrip("/"))

[aminalaee]

I think urljoin will do that so:

self.base_url=urljoin(app.root_path, base_url)

[bikmetle]

i've tried different paths, the only working way is to do

self.base_url=urljoin(app.root_path+"/", base_url.lstrip("/"))

[aminalaee]

I think you are right, probably it should be changed to this:

self.base_url=os.path.join(app.root_path, base_url)

Also a few other points:

• tests should be added
• there's an existing code using urljoin which I think should be changed to os.path.join

[mmzeynalli]

@bikmetle reminder

[mmzeynalli]

LGTM

[mmzeynalli]

@aminalaee

[aminalaee]

@mmzeynalli I was waiting for this comment to be resolved. I think it's a small change but we should also add tests for it

[mmzeynalli]

@JartanFTW your PR #996 addresses this, right?

[JartanFTW]

@JartanFTW your PR #996 addresses this, right?

From my understanding, yes.

[mmzeynalli]

@bikmetle I'm closing this PR. Thanks for your work, but #996 handles this in a broader way.