misc: remove AwsHttpBindingProtocolGenerator #1470
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0marperez
added
the
no-changelog
…ic to generic module
0marperez
changed the title
ianbotsf
approved these changes
Dec 19, 2025
Comment on lines
+112
to
+119
| writer.withBlock( | ||
| "private fun ${op.errorHandlerName()}(context: #T, call: #T, payload: #T?): #Q {", | ||
| "}", | ||
| RuntimeTypes.Core.ExecutionContext, | ||
| RuntimeTypes.Http.HttpCall, | ||
| KotlinTypes.ByteArray, | ||
| KotlinTypes.Nothing, | ||
| ) { |
Contributor
There was a problem hiding this comment.
Nit: Mixing Kotlin string templates with CodeWriter substitutions makes our codegen harder to read. Let's replace "${op.errorHandlerName()}" with "#L".
Comment on lines
+143
to
+154
| .write("val errorDetails = try {") | ||
| .indent() | ||
| .call { | ||
| renderDeserializeErrorDetails(ctx, op, writer) | ||
| } | ||
| .dedent() | ||
| .withBlock("} catch (ex: Exception) {", "}") { | ||
| withBlock("""throw #T("Failed to parse response as '${ctx.protocol.name}' error", ex).also {""", "}", exceptionBaseSymbol) { | ||
| write("#T(it, wrappedCall.response, null)", RuntimeTypes.AwsProtocolCore.setAseErrorMetadata) | ||
| } | ||
| } | ||
| .write("") |
Contributor
There was a problem hiding this comment.
Nit: Let's replace these manual indent/dedent calls with withBlock and closeAndOpenBlock.
Comment on lines
+272
to
+278
| val ignoredTests = TestMemberDelta( | ||
| setOf( | ||
| // likely bug in Smithy's HTTP header traits spec | ||
| "RestJsonHttpEmptyPrefixHeadersRequestClient", | ||
| "HttpEmptyPrefixHeadersRequestClient", | ||
| ), | ||
| ) |
Contributor
There was a problem hiding this comment.
Question: Have we re-verified these omitted tests lately? Do we still need to ignore them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
Main change:
AwsHttpBindingProtocolGeneratorSecondary changes:
StaticHttpBindingResolverfrom AWS specific module to generic moduleBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.