Implement 'multigraph' protocol extension #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for the
multigraphprotocol extension.This PR implements processing when the
multigraphparameter is given in the cap command.This PR introduces a new
IMultigraphPlugininterface, which allows plugins to be implemented that support multiple graphs.This interface behaves as a single multigraph-aware plugin if
multigraphis enabled. If it is disabled, it will simply behaves as multiple plugins.Considerations
The default implementation of this PR will not change the environment variable
MUNIN_CAP_MULTIGRAPH.This PR changes the behavior of
MuninProtocolHandlerto cache the list ofIPlugins provided byIMuninNodeProfile.PluginProvider.This causes that the changes to
IMuninNodeProfile.PluginProviderwill not be reflected as long as the node is running.