Fix getSheet method to accept sheetId#162
Merged
ggoranov-smar merged 3 commits intomainlinefrom Mar 18, 2026
Merged
Conversation
Review completed. The latest commit adds a properly formatted changelog entry with no issues found. Summary:
No issues found. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
mkramolinski-smar
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
getSheetURL and parameter (#161)Problem
getSheetdoes not takesheetIdas the parameter name and routes to the/sheetscollection URL instead of/sheets/{sheetId}.Changes
lib/sheets/get.jsgetSheetfunction that builds the URL assheets/{sheetId}using the newbuildUrl(sheetId)helper.getSheetAsCSV,getSheetAsPDF, andgetSheetAsExcelto directly call the requestor withsheetId-based URLs instead of delegating tolistSheets._.extend(optionsToSend, ...)(mutating shared state) with spread syntax to prevent URL bleed-through between calls.README.md— Updated example to usesheetIdinstead ofid.endpoints.spec.tsandsheets.spec.tsto reflect the corrected parameter name and expected URLs.