Merged
Conversation
Reviewed changes since 62d86bc. The bug fix for issue #161 looks solid. The refactoring properly addresses the getSheet 404 error by introducing a buildUrl helper function and using consistent parameter naming (sheetId instead of id). Tests and documentation have been updated appropriately. No new issues found. Previous Recommendation (Completed):
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
smar-kaloyan-gangov
previously approved these changes
Mar 17, 2026
Contributor
smar-kaloyan-gangov
left a comment
smar-kaloyan-gangov
left a comment
There was a problem hiding this comment.
don't we need the package-lock.json too? Last time we added it
mkramolinski-smar
previously approved these changes
Mar 17, 2026
ggoranov-smar
dismissed stale reviews from mkramolinski-smar and smar-kaloyan-gangov
via
62d86bc
Contributor
Author
Good catch @smar-kaloyan-gangov. Updated it! |
smar-kaloyan-gangov
previously approved these changes
Mar 17, 2026
smar-kaloyan-gangov
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.