Fix log level check causing crashes.#159
Merged
ggoranov-smar merged 2 commits intomainlinefrom Mar 17, 2026
Merged
Conversation
Reviewed the latest changes. The test for 'silly' log level has been added. All issues have been addressed.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![roomote-v0[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
smar-kaloyan-gangov
previously approved these changes
Mar 17, 2026
mkramolinski-smar
approved these changes
Mar 17, 2026
smar-kaloyan-gangov
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #158
After upgrading to v4.7.1, applications using the
logLeveloption crashed immediately on client initialization.This PR fixes it and adds tests for it. Additionally mock API tests now configure logger as an additional check in a real use case.