-
Notifications
You must be signed in to change notification settings - Fork 23
Add Update Report Definition support #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
smcgowan-smartsheet
wants to merge
8
commits into
smartsheet:mainline
Choose a base branch
from
smcgowan-smartsheet:feat/update_report_definition
base: mainline
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9884f92
feat: add support for update report definition endpoints
smcgowan-smartsheet 5abfb50
feat: add support for update report definition endpoints
smcgowan-smartsheet 200f8cb
feat: add support for update report definition endpoint
smcgowan-smartsheet c3ae057
feat: add support for add report columns
smcgowan-smartsheet e496e0b
feat: add support for add report columns
smcgowan-smartsheet 54d5dd4
feat: update report definition response body update
smcgowan-smartsheet 18491de
feat: update report definition response
smcgowan-smartsheet 7757db4
chore: update documentation
smcgowan-smartsheet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
140 changes: 140 additions & 0 deletions
140
src/main/java/com/smartsheet/api/models/ReportColumnIdentifier.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,140 @@ | ||
| /* | ||
| * Copyright (C) 2025 Smartsheet | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.smartsheet.api.models; | ||
|
|
||
| import com.smartsheet.api.models.enums.ColumnType; | ||
| import com.smartsheet.api.models.enums.ReportSystemColumnType; | ||
|
|
||
| /** | ||
| * Object used to match a sheet column for a report. | ||
| * <p> | ||
| * One of [{@code type}, {@code systemColumnType}] or [{@code primary=true}] is required. | ||
| * <p> | ||
| * {@code systemColumnType} should be specified if you want to match a system column. Use {@code primary=true} | ||
| * to match primary columns. When matching primary columns, {@code title} can be used to customize the primary | ||
| * column name in the rendered report. | ||
| * <p> | ||
| * <b>Note:</b> Columns in the report are matched by the combination of {@code title} and {@code type} | ||
| * (and {@code systemColumnType} if specified). | ||
| * <p> | ||
| * <b>Note:</b> {@code symbol} is not used for matching and as a result {@code CHECKBOX} or {@code PICKLIST} | ||
| * columns with different symbols (from different sheets) can be combined into the same column in the report. | ||
| * You cannot combine {@code CHECKBOX} with {@code PICKLIST} into the same column in the report because they | ||
| * are different types. | ||
| */ | ||
| public class ReportColumnIdentifier { | ||
|
|
||
| /** | ||
| * Column title to be matched from the source sheets. | ||
| * <p> | ||
| * Note: If {@code primary} is true, then this property can be used to customize the primary column title. | ||
| */ | ||
| private String title; | ||
|
|
||
| /** | ||
| * Column type to be matched from the source sheets. | ||
| */ | ||
| private ColumnType type; | ||
|
|
||
| /** | ||
| * System column type to be matched from the source sheets. | ||
| */ | ||
| private ReportSystemColumnType systemColumnType; | ||
|
|
||
| /** | ||
| * Indicates if the matched column is primary (default: false). | ||
| */ | ||
| private Boolean primary; | ||
|
|
||
| /** | ||
| * Gets the column title. | ||
| * | ||
| * @return the title | ||
| */ | ||
| public String getTitle() { | ||
| return title; | ||
| } | ||
|
|
||
| /** | ||
| * Sets the column title. | ||
| * <p> | ||
| * If primary is true, this can be used to customize the primary column title in the report. | ||
| * | ||
| * @param title the title | ||
| */ | ||
| public ReportColumnIdentifier setTitle(String title) { | ||
| this.title = title; | ||
| return this; | ||
| } | ||
|
|
||
| /** | ||
| * Gets the column type. | ||
| * | ||
| * @return the type | ||
| */ | ||
| public ColumnType getType() { | ||
| return type; | ||
| } | ||
|
|
||
| /** | ||
| * Sets the column type. | ||
| * | ||
| * @param type the type | ||
| */ | ||
| public ReportColumnIdentifier setType(ColumnType type) { | ||
| this.type = type; | ||
| return this; | ||
| } | ||
|
|
||
| /** | ||
| * Gets the system column type. | ||
| * | ||
| * @return the system column type | ||
| */ | ||
| public ReportSystemColumnType getSystemColumnType() { | ||
| return systemColumnType; | ||
| } | ||
|
|
||
| /** | ||
| * Sets the system column type. | ||
| * | ||
| * @param systemColumnType the system column type | ||
| */ | ||
| public ReportColumnIdentifier setSystemColumnType(ReportSystemColumnType systemColumnType) { | ||
| this.systemColumnType = systemColumnType; | ||
| return this; | ||
| } | ||
|
|
||
| /** | ||
| * Gets whether this identifies the primary column. | ||
| * | ||
| * @return true if this is the primary column, false otherwise | ||
| */ | ||
| public Boolean getPrimary() { | ||
| return primary; | ||
| } | ||
|
|
||
| /** | ||
| * Sets whether this identifies the primary column. | ||
| * | ||
| * @param primary true if this is the primary column, false otherwise | ||
| */ | ||
| public ReportColumnIdentifier setPrimary(Boolean primary) { | ||
| this.primary = primary; | ||
| return this; | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.