Skip to content

Prevent HTTP connection leak on network exceptions #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
efilipowicz wants to merge 1 commit into
base: mainline
Choose a base branch
from
Open

Prevent HTTP connection leak on network exceptions #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/com/smartsheet/api/internal/http/DefaultHttpClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,7 @@ public HttpResponse request(HttpRequest smartsheetRequest) throws HttpClientExce
this.releaseConnection();

} catch (ClientProtocolException e) {
this.releaseConnection();
logger.warn("ClientProtocolException " + e.getMessage());
logger.warn(LOG_ARG, RequestAndResponseData.of(apacheHttpRequest, requestEntityCopy, smartsheetResponse,
responseEntityCopy, REQUEST_RESPONSE_SUMMARY));
Expand All @@ -305,6 +306,7 @@ public HttpResponse request(HttpRequest smartsheetRequest) throws HttpClientExce
}
throw new HttpClientException(ERROR_OCCURRED, e);
} catch (NoHttpResponseException e) {
this.releaseConnection();
logger.warn("NoHttpResponseException {}", e.getMessage());
logger.warn(LOG_ARG, RequestAndResponseData.of(apacheHttpRequest, requestEntityCopy, smartsheetResponse,
responseEntityCopy, REQUEST_RESPONSE_SUMMARY));
Expand All @@ -322,6 +324,7 @@ public HttpResponse request(HttpRequest smartsheetRequest) throws HttpClientExce
}
throw new HttpClientException(ERROR_OCCURRED, e);
} catch (IOException e) {
this.releaseConnection();
logger.warn(LOG_ARG, RequestAndResponseData.of(apacheHttpRequest, requestEntityCopy, smartsheetResponse,
responseEntityCopy, REQUEST_RESPONSE_SUMMARY));
throw new HttpClientException(ERROR_OCCURRED, e);
Expand Down
Loading