More performant compact map #344
Open
+19
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dubiousdavid
commented
Feb 21, 2022
dubiousdavid
commented
- More performant compact map.
- Fix stuff Babel was complaining about.
Contributor
…re/futil-js into feature/performant-compactMap
warrenv
reviewed
Feb 21, 2022
daedalus28
suggested changes
Feb 22, 2022
| export let compactMap = _.curry((fn, collection) => | ||
| _.flow(_.map(fn), _.compact)(collection) | ||
| ) | ||
| export let compactMap = _.curry((iteratee, collection) => { |
Contributor
There was a problem hiding this comment.
Can we do a quick benchmark? Lodash supports shortcut fusion which should be effectively the same thing. My first feedback was gonna be to do this with transducers https://runkit.com/daedalus28/transducer-example but lodash does this automatically in some cases - might only be only explicit chain calls though.
Member
Author
There was a problem hiding this comment.
Fusion is only supported in the chain scenario. https://lodash.com/docs/4.17.15#lodash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.