You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Release command: Removed Node.js dependencies, now uses Git tags as the source of truth for versioning. Auto-detects version files for multiple languages (Node.js, Python, Rust, PHP, Ruby, Go).
TDD skill: Added new tdd skill for Test-Driven Development workflow guidance.
Changes
command/release.md
Use git describe --tags instead of node -p "require('./package.json').version"
Fallback to 0.0.0 if no tags exist (instead of reading package.json)
Auto-detect version files based on project type
skill/tdd/SKILL.md (new)
TDD workflow: Requirement Synthesis → Test Specification → Implementation
Mandatory rules: No Test No Code, Black-Box Testing
Line 7: The fallback to 0.0.0 is good, but consider adding a check for valid semver format in the git tag output to avoid potential issues with malformed tags.
Line 40-46: The auto-detection of version files is a great improvement. However, the implementation should handle cases where multiple version files exist (e.g., both package.json and pyproject.toml in a polyglot repo). Consider adding a priority order or user confirmation for such cases.
Line 46: For Go projects, since there's no version file, consider adding guidance on how the version should be communicated (e.g., through module version or documentation).
skill/tdd/SKILL.md
Line 15: "Requirement Synthesis" is a good step, but consider adding a sub-step to validate requirements with the user before proceeding to test writing.
Line 21: The "No Test, No Code" rule is excellent. However, consider adding a note about how to handle legacy codebases where tests might not exist yet.
Line 35-39: The exceptions list is comprehensive. Consider adding a note about documenting exceptions in commit messages or pull requests for traceability.
General Comments
The changes align well with the goal of making the release command language-agnostic and adding TDD guidance.
The TDD skill document is well-structured and provides clear guidelines for implementation.
Consider adding examples or templates for the TDD workflow to make it more actionable for users.
Potential Bugs
In command/release.md, line 7-8: The git commands might fail in repositories with no commits or tags. Consider adding error handling or user-friendly messages for these edge cases.
In command/release.md, line 40-46: The auto-detection logic might not handle edge cases like missing files or permission issues. Consider adding validation steps before attempting to update files.
Suggestions for Improvement
Add a section in command/release.md about handling pre-release versions (e.g., v1.0.0-alpha) and how they should be treated in the version bump logic.
In skill/tdd/SKILL.md, consider adding a section on how to handle flaky tests or tests that are difficult to write due to external dependencies.
For both files, consider adding more examples or templates to illustrate the concepts and workflows described.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tddskill for Test-Driven Development workflow guidance.Changes
command/release.mdgit describe --tagsinstead ofnode -p "require('./package.json').version"0.0.0if no tags exist (instead of readingpackage.json)skill/tdd/SKILL.md(new)