Skip to content

Fix/reset timeout for tts.speak #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
YuriiYefimenko wants to merge 5 commits into from
Closed

Fix/reset timeout for tts.speak #445

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9409ef1
Fix reset timeout for TTS.Speak
YuriiYefimenko Aug 20, 2021
de24d8a
Add requestID to the onResetTimeout
YuriiYefimenko Aug 25, 2021
cf2c7ff
Add requestID to the onResetTimeout
YuriiYefimenko Aug 26, 2021
beff499
fix indentation
YuriiYefimenko Aug 26, 2021
a6735e5
Update src/js/Controllers/TTSController.js
YuriiYefimenko Sep 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/js/Controllers/TTSController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,7 @@ class TTSController {

this.listener.send(RpcFactory.TTSStartedNotification());
this.playNext();
if(!rpc.params.speakType.includes('ALERT'))
this.timers[rpc.id] = setInterval(this.onResetTimeout, 9000, rpc.params.appID, "TTS.Speak");
this.timers[rpc.id] = setInterval(this.onResetTimeout, 9000, rpc.id);
Copy link
Collaborator

@iCollin iCollin Sep 20, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this.timers[rpc.id] = setInterval(this.onResetTimeout, 9000, rpc.id);
if(!rpc.params.speakType.includes('ALERT'))
this.timers[rpc.id] = setInterval(this.onResetTimeout, 9000, rpc.id);

#444 (comment)

Copy link
Collaborator

@iCollin iCollin Sep 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YuriiYefimenko we have closed #444, can you please make adjustments to ensure onResetTimeout is not sent when the TTS Speak is part of an Alert or AlertManeuver or apply the above suggestion? Thank you!

return null;
case "StopSpeaking":
if (this.currentlyPlaying) {
Expand Down