Skip to content

Make the group package public #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pszal merged 3 commits into from
Jun 24, 2025
Merged

Make the group package public #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
272a574
internal/group -> lib/group
pszal Jun 23, 2025
2f89fe2
bump deprecated actions/upload-artifact and actions/download-artifact
pszal Jun 23, 2025
a39db8d
fix golangci skip-dirs
pszal Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/go.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ jobs:
find . -name "go.mod" -execdir $(go env GOPATH)/bin/golangci-lint run
--timeout=2m0s
--out-format=checkstyle:golangci-lint-report.xml
--skip-dirs="internal/group/" \;
--skip-dirs="lib/group/" \;

- name: Check golangci-lint report for errors
run: find . -name "golangci-lint-report.xml" -exec grep "error" {} + && exit 1 || true

- name: Upload golangci-lint report
if: always()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: golangci-lint-report
path: |
Expand Down Expand Up @@ -88,7 +88,7 @@ jobs:

- name: Upload Go test reports
if: always()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: go-test-results
path: |
Expand All @@ -110,7 +110,7 @@ jobs:
fetch-depth: 0 # fetch all history for all tags and branches to provide more metadata for sonar reports

- name: Download all workflow run artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4

- name: Update golangci-lint report symlinks
# When golangci-lint is run in a multimodule project, it creates a report with relative paths to the files which should be updated
Expand Down
0 go/tdh2/internal/group/LICENSE → go/tdh2/lib/group/LICENSE
View file
Open in desktop
File renamed without changes.
0 go/tdh2/internal/group/group.go → go/tdh2/lib/group/group.go
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion go/tdh2/internal/group/mod/int.go → go/tdh2/lib/group/mod/int.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"errors"
"math/big"

"github.com/smartcontractkit/tdh2/go/tdh2/internal/group"
"github.com/smartcontractkit/tdh2/go/tdh2/lib/group"
)

// Int is a generic implementation of finite field arithmetic
Expand Down
0 go/tdh2/internal/group/mod/int_test.go → go/tdh2/lib/group/mod/int_test.go
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions go/tdh2/internal/group/nist/curve.go → go/tdh2/lib/group/nist/curve.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ import (
"fmt"
"math/big"

"github.com/smartcontractkit/tdh2/go/tdh2/internal/group"
"github.com/smartcontractkit/tdh2/go/tdh2/internal/group/mod"
"github.com/smartcontractkit/tdh2/go/tdh2/lib/group"
"github.com/smartcontractkit/tdh2/go/tdh2/lib/group/mod"
)

// streamReader implements io.Reader from cipher.Stream
Expand Down
4 changes: 2 additions & 2 deletions go/tdh2/internal/group/nist/group_test.go → go/tdh2/lib/group/nist/group_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import (
"bytes"
"testing"

"github.com/smartcontractkit/tdh2/go/tdh2/internal/group"
"github.com/smartcontractkit/tdh2/go/tdh2/internal/group/test"
"github.com/smartcontractkit/tdh2/go/tdh2/lib/group"
"github.com/smartcontractkit/tdh2/go/tdh2/lib/group/test"
)

var benchmarks = []*test.GroupBench{
Expand Down
2 changes: 1 addition & 1 deletion go/tdh2/internal/group/share/poly.go → go/tdh2/lib/group/share/poly.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (
"sort"
"strings"

"github.com/smartcontractkit/tdh2/go/tdh2/internal/group"
"github.com/smartcontractkit/tdh2/go/tdh2/lib/group"
)

// PriShare represents a private share.
Expand Down
4 changes: 2 additions & 2 deletions go/tdh2/internal/group/share/poly_test.go → go/tdh2/lib/group/share/poly_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import (
"crypto/rand"
"testing"

"github.com/smartcontractkit/tdh2/go/tdh2/internal/group"
"github.com/smartcontractkit/tdh2/go/tdh2/internal/group/nist"
"github.com/smartcontractkit/tdh2/go/tdh2/lib/group"
"github.com/smartcontractkit/tdh2/go/tdh2/lib/group/nist"
)

var groups = []group.Group{
Expand Down
2 changes: 1 addition & 1 deletion go/tdh2/internal/group/test/group.go → go/tdh2/lib/group/test/group.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package test

import (
"github.com/smartcontractkit/tdh2/go/tdh2/internal/group"
"github.com/smartcontractkit/tdh2/go/tdh2/lib/group"
)

// GroupBench is a generic benchmark suite for group.groups.
Expand Down
2 changes: 1 addition & 1 deletion go/tdh2/internal/group/test/test.go → go/tdh2/lib/group/test/test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
"crypto/rand"
"testing"

"github.com/smartcontractkit/tdh2/go/tdh2/internal/group"
"github.com/smartcontractkit/tdh2/go/tdh2/lib/group"
)

func testPointSet(t *testing.T, g group.Group, rand cipher.Stream) {
Expand Down
6 changes: 3 additions & 3 deletions go/tdh2/tdh2/tdh2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ import (
"encoding/json"
"fmt"

"github.com/smartcontractkit/tdh2/go/tdh2/internal/group"
"github.com/smartcontractkit/tdh2/go/tdh2/internal/group/nist"
"github.com/smartcontractkit/tdh2/go/tdh2/internal/group/share"
"github.com/smartcontractkit/tdh2/go/tdh2/lib/group"
"github.com/smartcontractkit/tdh2/go/tdh2/lib/group/nist"
"github.com/smartcontractkit/tdh2/go/tdh2/lib/group/share"
)

var (
Expand Down
4 changes: 2 additions & 2 deletions go/tdh2/tdh2/tdh2_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ import (

"github.com/google/go-cmp/cmp"
"github.com/google/go-cmp/cmp/cmpopts"
"github.com/smartcontractkit/tdh2/go/tdh2/internal/group"
"github.com/smartcontractkit/tdh2/go/tdh2/internal/group/nist"
"github.com/smartcontractkit/tdh2/go/tdh2/lib/group"
"github.com/smartcontractkit/tdh2/go/tdh2/lib/group/nist"
)

var supportedGroups = []string{
Expand Down
2 changes: 1 addition & 1 deletion go/tdh2/tdh2easy/tdh2easy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"encoding/json"
"fmt"

"github.com/smartcontractkit/tdh2/go/tdh2/internal/group/nist"
"github.com/smartcontractkit/tdh2/go/tdh2/lib/group/nist"
"github.com/smartcontractkit/tdh2/go/tdh2/tdh2"
)

Expand Down
2 changes: 1 addition & 1 deletion go/tdh2/tdh2easy/tdh2easy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (

"github.com/google/go-cmp/cmp"
"github.com/google/go-cmp/cmp/cmpopts"
"github.com/smartcontractkit/tdh2/go/tdh2/internal/group/nist"
"github.com/smartcontractkit/tdh2/go/tdh2/lib/group/nist"
"github.com/smartcontractkit/tdh2/go/tdh2/tdh2"
)

Expand Down
Loading