[CRE-1924] Support DONtime plugin config in CLD

[bolekk]

No description provided.

[github-actions]

👋 bolekk, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

[github-actions]

✅ No conflicts with other open PRs targeting develop

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[trunk-io]

🔴 Test Results: OCR3 Config Digest Mismatch

Affected failures:

1. Workflow Run: Run CCIP integration In Memory Tests For PR / smoke/ccip/ccip_messaging_test.go:Test_CCIPMessaging_Solana2EVM_LOOPP
2. Workflow Run: Run CCIP integration In Memory Tests For PR / smoke/ccip/ccip_token_transfer_test.go:*_LOOPP

What Broke

The introduction of DontimeOffchainConfig to the OracleConfig struct has led to an 'OCR3 config digest mismatch' for CCIP plugins. This issue stems from two related problems: the DontimeOffchainConfig field was not correctly unmarshalled, causing expected offchain configurations to be unset, and the serialization of existing OCR3 configurations was altered due to the new field, leading to incorrect digest calculations.

Proposed Fixes

Update the OracleConfig struct by adding json:",omitempty" tags to relevant fields and modify the UnmarshalJSON method to correctly unmarshal the DontimeOffchainConfig field.

In oracle_config.go:36

 \tMaxFaultyOracles int
- \tConsensusCapOffchainConfig *ConsensusCapOffchainConfig
+ \tConsensusCapOffchainConfig *ConsensusCapOffchainConfig `json:",omitempty"`
- \tChainCapOffchainConfig     *ChainCapOffchainConfig
+ \tChainCapOffchainConfig     *ChainCapOffchainConfig     `json:",omitempty"`
- \tDontimeOffchainConfig      *DontimeOffchainConfig
+ \tDontimeOffchainConfig      *DontimeOffchainConfig      `json:",omitempty"`
 }

In oracle_config.go:42

 \t\tChainCapOffchainConfig     *json.RawMessage `json:"ChainCapOffchainConfig"`
+ \t\tDontimeOffchainConfig      *json.RawMessage `json:"DontimeOffchainConfig"`
 \t\t*aliasT

In oracle_config.go:65

+
+ \tif temp.DontimeOffchainConfig != nil {
+ \t\tvar c DontimeOffchainConfig
+ \t\tif err := json.Unmarshal(*temp.DontimeOffchainConfig, &c); err != nil {
+ \t\t\treturn fmt.Errorf("failed to unmarshal DontimeOffchainConfig: %w", err)
+ \t\t}
+ \t\toc.DontimeOffchainConfig = &c
+ \t}

 \treturn nil

Autofix Options

You can apply the proposed fixes directly to your branch. Try the following:

• Comment /trunk stack-fix lJpQ7P3t to generate a stacked PR with the proposed fixes.
• Use MCP in your IDE to fix the issue. Try Help me fix CI failures from lJpQ7P3t to get started.

Tip

Get Better Results: This CI job is not uploading test reports. Adding structured test reports enables more precise, test-level analysis with better root cause identification and more targeted fix recommendations.
👉🏻 Learn how to upload test results.

[trunk-io]

🔴 Test Results: Unrelated Failure

Affected failures:

1. Workflow Run: Integration Tests

What Broke

The json.Unmarshal operation in the TestConfigureCapabilitiesRegistryInput_YAMLFromFile_DontimeConfig test is populating more than one offchain configuration field in the ocr3.OracleConfig struct. The CI failure is caused by a test that attempts to unmarshal a YAML configuration containing dontimeOffchainConfig into an ocr3.OracleConfig struct. The json.Unmarshal operation incorrectly populates multiple offchain configuration fields in the ocr3.OracleConfig, leading to an error in the getOffchainCfg function which enforces that only one offchain config can be present.

Autofix Options

You can use our MCP server to get AI assistance with debugging and fixing these failures.

• Use MCP in your IDE to debug the issue. Try Help me fix CI failures from alRWPuOn to get started.

Tip

Get Better Results: This CI job is not uploading test reports. Adding structured test reports enables more precise, test-level analysis with better root cause identification and more targeted fix recommendations.
👉🏻 Learn how to upload test results.

[trunk-io]

     

View Full Report ↗︎ ⋅ Docs