Skip to content

Comments

[CRE][Deployments] Fix bug in OCR config count extraction#21295

Merged
bolekk merged 1 commit intodevelopfrom
configcount_fix
Feb 24, 2026
Merged

[CRE][Deployments] Fix bug in OCR config count extraction#21295
bolekk merged 1 commit intodevelopfrom
configcount_fix

Conversation

@bolekk
Copy link
Contributor

@bolekk bolekk commented Feb 24, 2026

Remove unnecessary JSON conversion that was messing up the types.

@github-actions
Copy link
Contributor

👋 bolekk, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026

✅ No conflicts with other open PRs targeting develop

@cl-sonarqube-production
Copy link

Copy link

@trunk-io trunk-io bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Test Results: Base64 Decoding Error

Affected failures:

  1. Workflow Run: Run CCIP integration In Memory Tests For PR / smoke/ccip/ccip_messaging_test.go:Test_CCIPMessaging_Solana2EVM_LOOPP

What Broke

The extractOCR3ConfigCount function in deployment/cre/ocr3/registry_config.go attempts to unmarshal a base64 encoded protobuf configuration directly without first decoding it, leading to an unmarshalling failure.

Proposed Fixes

Update the extractOCR3ConfigCount function to base64 decode the raw configuration before unmarshalling it as a protobuf message.

In registry_config.go:125

+ 	decodedConfig, err := base64.StdEncoding.DecodeString(string(rawConfig))
+ 	if err != nil {
+ 		return 0, fmt.Errorf("failed to base64 decode capability config: %w", err)
+ 	}
- 	if err := proto.Unmarshal(rawConfig, pbCfg); err != nil;
+ 	if err := proto.Unmarshal(decodedConfig, pbCfg); err != nil;
Autofix Options

You can apply the proposed fixes directly to your branch. Try the following:

  • Comment /trunk stack-fix 6JAMCLGE to generate a stacked PR with the proposed fixes.
  • Use MCP in your IDE to fix the issue. Try Help me fix CI failures from 6JAMCLGE to get started.

View all test uploads

@bolekk bolekk added this pull request to the merge queue Feb 24, 2026
Merged via the queue into develop with commit b68ce64 Feb 24, 2026
220 of 223 checks passed
@bolekk bolekk deleted the configcount_fix branch February 24, 2026 20:23
@trunk-io
Copy link

trunk-io bot commented Feb 24, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants