Conversation
|
👋 matYang, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
There was a problem hiding this comment.
Pull request overview
This PR implements the DisableRemoteChain method for the TON lane adapter by adding a panic placeholder, indicating that this functionality is not yet supported for TON chains.
Changes:
- Added
DisableRemoteChainmethod toTonLaneAdapterthat panics with a "not implemented" message
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| func (a *TonLaneAdapter) DisableRemoteChain() *cldf_ops.Sequence[lanes.DisableRemoteChainInput, sequences.OnChainOutput, cldfChain.BlockChains] { | ||
| panic("DisableRemoteChain not implemented for TON") |
There was a problem hiding this comment.
The panic message should follow Go conventions by starting with a lowercase letter and including the method/type context. Consider changing to 'tonLaneAdapter.DisableRemoteChain: not implemented' for consistency with standard Go error formatting.
| panic("DisableRemoteChain not implemented for TON") | |
| panic("tonLaneAdapter.DisableRemoteChain: not implemented") |
|
@ma33r is also modifying the MCMS interface to allow updating configs, so we'll want to add that API call here too |
|
I think you also need to bump github.com/smartcontractkit/chainlink-ccip/deployment |
No description provided.