Add confidential-workflows capability proto#298
Conversation
New capability proto at cre/capabilities/compute/confidentialworkflow/v1alpha/client.proto following the confidential-http pattern: ConfidentialWorkflowRequest wraps SecretIdentifier list + WorkflowExecution (public data for the enclave).
|
product-security-plaid-production
bot
requested review from
ChrisAmora and
Unheilbar
|
👋 nadahalli, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
product-security-plaid-production
bot
requested a review
from prashantkumar1982
|
The latest Buf updates on your PR. Results from workflow Regenerate Protobuf Files / buf (pull_request).
|
| message SecretIdentifier { | ||
| string key = 1; | ||
| string namespace = 2; | ||
| optional string owner = 3; |
There was a problem hiding this comment.
Can we just get rid of it?
There was a problem hiding this comment.
Are we sure that the owner thing is resolved? I am happy to remove it.
|
|
||
| message SecretIdentifier { | ||
| string key = 1; | ||
| string namespace = 2; |
There was a problem hiding this comment.
this perhaps can be optional. set to "main" if missing.
There was a problem hiding this comment.
Good call. Made it optional, defaults to "main" server-side when unset. See 2fedc0c.
|
Implementation plan: Confidential CRE Workflows (full PR chain and cross-repo dependencies) |
2 participants
Summary
cre/capabilities/compute/confidentialworkflow/v1alpha/client.protoConfidentialWorkflowRequestwraps aSecretIdentifierlist +WorkflowExecution(public data for the enclave)WorkflowExecutioncarries workflow ID, binary URL/hash, and a serializedsdk.ExecuteRequest(trigger or subscribe)ExecuteRPC, capability IDconfidential-workflows@1.0.0-alpha, MODE_DONgo generate