This repository was archived by the owner on Mar 17, 2026. It is now read-only.
Conversation
For ccip-js package only. Update package.json scripts, README, and TypeScript configuration - Marked FeeQuoter as Abstract and removed inherit natspec from IFeeQuoter onconvertTokenAmount() - Cleaned up test files by removing unnecessary imports and added a completion message for integration tests. - Modified unit test script in package.json to target specific unit test files. - Updated package README with detailed local development instructions and ABI handling. - Updated tsconfig.json to enforce stricter TypeScript checks with noUnusedLocals and noUnusedParameters. - Removed unused ABI imports in api.ts and adjusted FeeQuoter contract to be abstract.
was producing incorrect error that hardhat config needed .cjs extension -- when it already had that. Updating node version fixed it.
timweri
reviewed
Jun 5, 2025
|
|
||
| - name: Setup Node 18.x | ||
| - name: Setup Node 20.x | ||
| uses: actions/setup-node@v3 |
timweri
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CI build error on publish dry run.
For ccip-js package only.