Skip to content

rysnc replacement with cp and tar. (og. More aggressive pattern copy + rsync replacement.) #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PortalG wants to merge 4 commits into
base: main
Choose a base branch
from
+13 −12
Open

rysnc replacement with cp and tar. (og. More aggressive pattern copy + rsync replacement.) #987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1594925
Replaced rsync implementation with cp and tar, and made Robocopy copy…
PortalG Mar 8, 2026
208d33d
Cleaned up formating and fixed typos.
PortalG Mar 9, 2026
46bd1c3
Merge branch 'main' into better-copy
PortalG Mar 21, 2026
e8e7841
Replaced rsync with tar and cp.
PortalG Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cmake/CopyFileScript.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,12 @@ if(CMAKE_HOST_WIN32)

elseif(CMAKE_HOST_UNIX)
execute_process(
COMMAND rsync -av ${COPY_SOURCE} "${COPY_DEST}/"
RESULT_VARIABLE rs
COMMAND cp -av "${COPY_SOURCE}/" "${COPY_DEST}/"
RESULT_VARIABLE cp
)

if(rs GREATER 0) # Any non-zero exit code indicates an error
message(FATAL_ERROR "rsync failed (exit code ${rs})")
if(cp GREATER 0) # Any non-zero exit code indicates an error
message(FATAL_ERROR "cp failed (exit code ${cp})")
endif()
else()
message(FATAL_ERROR "Unsupported host platform for asset copying.")
Expand Down
17 changes: 9 additions & 8 deletions cmake/CopyFolderScript.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,24 +46,25 @@ if(CMAKE_HOST_WIN32)
message(FATAL_ERROR "robocopy failed (exit code ${rc})")
endif()
elseif(CMAKE_HOST_UNIX)
set(rsync_args -av)
set(tar_args)

foreach(pattern IN LISTS EXCLUDE_FILES)
list(APPEND rsync_args "--exclude=${pattern}")
list(APPEND tar_args "--exclude=${pattern}")
endforeach()

foreach(pattern IN LISTS EXCLUDE_FOLDERS)
list(APPEND rsync_args "--exclude=${pattern}")
list(APPEND tar_args "--exclude=${pattern}")
endforeach()

# Trailing slashes ensure rsync copies contents, not the directory itself
# Trailing slashes ensure tar copies contents, not the directory itself
execute_process(
COMMAND rsync ${rsync_args} "${COPY_SOURCE}/" "${COPY_DEST}/"
RESULT_VARIABLE rs
COMMAND tar ${tar_args} -cf - -C "${COPY_SOURCE}/" .
COMMAND tar -xvf - -C "${COPY_DEST}/"
RESULT_VARIABLE tr
)

if(rs GREATER 0) # Any non-zero exit code indicates an error
message(FATAL_ERROR "rsync failed (exit code ${rs})")
if(tr GREATER 0) # Any non-zero exit code indicates an error
message(FATAL_ERROR "tar failed (exit code ${tr})")
endif()
else()
message(FATAL_ERROR "Unsupported host platform for asset copying.")
Expand Down
Loading