Skip to content

Fix: The buttons in the some menus do not make a clicking sound #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Adem-Kurt wants to merge 4 commits into
base: main
Choose a base branch
from
+10 −2
Open

Fix: The buttons in the some menus do not make a clicking sound #1350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab8393c
Fix: The buttons in the Help and Options menu do not make a clicking …
Adem-Kurt Mar 19, 2026
b9c55c2
Fix: The buttons in the Debug menu do not make a clicking sound
Adem-Kurt Mar 19, 2026
558f4a7
Fix: The buttons in the Death menu do not make a clicking sound
Adem-Kurt Mar 19, 2026
26505c7
Fix: The buttons in the Pause menu do not make a clicking sound
Adem-Kurt Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Minecraft.Client/Common/UI/UIScene_DeathMenu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ void UIScene_DeathMenu::handleInput(int iPad, int key, bool repeat, bool pressed

void UIScene_DeathMenu::handlePress(F64 controlId, F64 childId)
{
ui.PlayUISFX(eSFX_Press);

switch(static_cast<int>(controlId))
{
case eControl_Respawn:
Expand Down Expand Up @@ -188,4 +190,4 @@ void UIScene_DeathMenu::handlePress(F64 controlId, F64 childId)
}
break;
}
}
}
2 changes: 2 additions & 0 deletions Minecraft.Client/Common/UI/UIScene_DebugOverlay.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,8 @@ void UIScene_DebugOverlay::handleInput(int iPad, int key, bool repeat, bool pres

void UIScene_DebugOverlay::handlePress(F64 controlId, F64 childId)
{
ui.PlayUISFX(eSFX_Press);

switch(static_cast<int>(controlId))
{
case eControl_Items:
Expand Down
2 changes: 2 additions & 0 deletions Minecraft.Client/Common/UI/UIScene_HelpAndOptionsMenu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,8 @@ void UIScene_HelpAndOptionsMenu::handleInput(int iPad, int key, bool repeat, boo

void UIScene_HelpAndOptionsMenu::handlePress(F64 controlId, F64 childId)
{
ui.PlayUISFX(eSFX_Press);

switch(static_cast<int>(controlId))
{
case BUTTON_HAO_CHANGESKIN:
Expand Down
4 changes: 3 additions & 1 deletion Minecraft.Client/Common/UI/UIScene_PauseMenu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,6 +504,8 @@ void UIScene_PauseMenu::handleInput(int iPad, int key, bool repeat, bool pressed

void UIScene_PauseMenu::handlePress(F64 controlId, F64 childId)
{
ui.PlayUISFX(eSFX_Press);

if(m_bIgnoreInput) return;

switch(static_cast<int>(controlId))
Expand Down Expand Up @@ -1478,4 +1480,4 @@ bool UIScene_PauseMenu::CheckForPatch()

return bPatchAvailable;
}
#endif
#endif
Loading