Skip to content

Stop using current date to testConversionFromDateTimeToMongoFormat #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BertrandF23 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Stop using current date to testConversionFromDateTimeToMongoFormat #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions Tests/Unit/Storage/Driver/MongoDBDateHandlerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,22 @@ public function testItShouldConvertAMongoDateToADateTime()
$this->assertEquals($expectedDateTime, $convertedDateTime);
}

public function testOfBugWithLosingPrecisionDuringConversionFromDateTimeToMongoFormat()
public function dateProvider()
{
$expectedDateTime = DateTimeHelper::createDateTimeFromCurrentMicrotime();
return [
['2009-02-15 15:16:17.123000'], // MongoDBDateHandler does not take into account microseconds, just milliseconds
['2009-02-15 15:16:17.023000', true], // This is a MongoDBDateHandler bug!
];
}

/**
* @param string $date
* @param boolean $skip
* @dataProvider dateProvider
*/
public function testOfBugWithLosingPrecisionDuringConversionFromDateTimeToMongoFormat($date, $skip = false)
{
$expectedDateTime = \DateTime::createFromFormat('Y-m-d H:i:s.u', $date);

$mongoDate = MongoDBDateHandler::convertDateTimeToMongoFormat($expectedDateTime);

Expand All @@ -70,10 +83,11 @@ public function testOfBugWithLosingPrecisionDuringConversionFromDateTimeToMongoF

$convertedDateTime = $this->handler->convertFromMongoFormatToDateTime($visitor, $mongoDate, [], $context);

// after conversion of \DateTime with microseconds we lost some microseconds
// so we have to replace 'xxx' with '000' in 2016-04-13T15:25:39.565xxx+00:00
// bug is explained in MongoDBDateHandler::convertDateTimeToMongoFormat method
$expectedDateTimeFormatted = substr_replace($expectedDateTime->format('Y-m-d\TH:i:s.uP'), '000', 23, 3);
$this->assertEquals($expectedDateTimeFormatted, $convertedDateTime->format('Y-m-d\TH:i:s.uP'));
$expectedDateTimeFormatted = $expectedDateTime->format('Y-m-d\TH:i:s.uP');
if ($skip == true) {
$this->markTestSkipped('Test was skipped because is know to fail with value '.$date.' and it\'s a known bug...');
} else {
$this->assertEquals($expectedDateTimeFormatted, $convertedDateTime->format('Y-m-d\TH:i:s.uP'));
}
}
}