Draft
Conversation
Still converging to the full domain.
Commented out the apply_boundary_conditions_neumann! function call.
Un-comment out apply_boundary_conditions_neumann! call in rhs
Sm/newmaster
Es/newmaster
this was a bug
rhs.jl improved for performance by small changes.
added 2 commits
January 16, 2026 13:58
# This is the 1st commit message: Update compat - force package version restrictions where necessary Reduce deps # This is the commit message #2: modified: test/runtests.jl
akshaysridhar
force-pushed
the
as/generalize-float
branch
from
1f4691a to
1ec4858
Compare
smarras79
approved these changes
Jan 22, 2026
Owner
|
@akshaysridhar is this still a draft? |
smarras79
force-pushed
the
master
branch
2 times, most recently
from
1cf58e6 to
edbbead
Compare
akshaysridhar
force-pushed
the
as/generalize-float
branch
from
d312c9f to
1ec4858
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hardcoded Float64