Enable denoise.py to work as script to avoid need for PYTHONPATH in env #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I must admit, we've not been using denoise for our rough benchmarking just yet, but we will probably do so in the future. |
smarr
force-pushed
the
avoid-using-pythonpath
branch
6 times, most recently
from
4d75f02 to
e6358fb
Compare
…e set in environment - make denoise.py executable for all - denoise.py does not support —version any longer, but that seems like an ok tradeoff Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
smarr
force-pushed
the
avoid-using-pythonpath
branch
from
e6358fb to
15169ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does away with some of the complexity around the
rebench-denoisecommand when used directly from rebench.denoise.pyis now an executable script with a shebang line, and executed directly.While
rebench-denoiseis convenient for command-line users, it expects a proper setup of Python and aPYTHONPATHthat allows the launcher script (generated by pip) to find the actual implementation.This meant we had to set
PYTHONPATHwhen using sudo to runrebench-denoise(as per #260), which could possibly interfere with Python programs running.Minor Changes
denoise.pyexecutable for alldenoise.py/rebench-denoisedoes not support--versionany longer, but that seems like an ok tradeoffRelated Issues
PYTHONPATHPYTHONPATH@martinmcclure this might impact you
@vext01 and you possibly, too.