feat: add Runtime.BEFORE_STEP event and use it for frame-synchronized broadcasts in meshV2 #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… broadcasts in meshV2 - Add Runtime.BEFORE_STEP event constant - Emit BEFORE_STEP event at the beginning of each frame step in Runtime._step() - Modify MeshV2Service to listen for BEFORE_STEP event - Replace setTimeout-based broadcast scheduling with a queue-based system in meshV2 - Add processNextBroadcast() to handle one broadcast per frame synchronized with runtime - Update unit tests to match the new frame-synchronized broadcast logic This ensures that multiple events received in a short time are processed across different frames, preventing Scratch threads from being restarted and lost. Issue: smalruby/smalruby3-gui#475 Related: smalruby/smalruby3-gui#473 Co-Authored-By: Gemini <noreply@google.com>
- Fix prefer-const, object-curly-spacing and no-multiple-empty-lines in mesh_service_v2.js - Fix no-unused-vars in mesh_service_v2_integration.js 🤖 Generated with [Gemini Code](https://gemini.google.com/code) Co-Authored-By: Gemini <noreply@google.com>
- Remove excessive blank lines between test declarations - Remove unnecessary blank lines within test bodies - Improve code readability and consistency 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…me synchronization - Update MeshV2Service to store offsetMs for each pending broadcast relative to batch start - Use Date.now() to accurately determine when each broadcast should fire - Ensure broadcasts are synchronized with Runtime.BEFORE_STEP (one per frame) - Update unit and integration tests to verify accurate timing and frame synchronization 🤖 Generated with [Gemini Code](https://gemini.google.com/code) Co-Authored-By: Gemini <noreply@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new
Runtime.BEFORE_STEPevent to Scratch VM and modifies the Mesh V2 extension to use this event for frame-synchronized broadcasts.Changes
BEFORE_STEPevent constant and emission at the beginning of each_step().MeshV2Serviceto listen forBEFORE_STEPevent.setTimeout-based broadcast scheduling with apendingBroadcastsqueue.processNextBroadcast()which executes one queued broadcast per frame step.Purpose
In Mesh V2 batch event sending, receiving multiple events in a short interval previously caused multiple broadcasts to fire in the same frame. Due to Scratch VM's behavior, this would restart the same message's scripts, causing processing to be lost. By synchronizing broadcasts with frame steps (one per frame), we ensure every event is correctly processed.
Related Issue: smalruby/smalruby3-gui#475
Related Issue: smalruby/smalruby3-gui#473