feat: implement batch event sending to optimize AppSync costs (#473) #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added event queue and batch sending logic every 250ms - Implemented fireEventsByNode mutation for batch delivery - Added onBatchEventInGroup subscription handling - Preserves event timing by using relative offsets from timestamps - Splits large batches (over 1000 events) to respect AppSync payload limits - Optimized RSSI calculation tests to be independent of environment variables GitHub Issue: scratchfoundation#473
- Verify timing reproduction of batched events - Verify splitting of large batches (over 1000 events) - Completes testing requirements for Issue scratchfoundation#473
- Change MIN_INTERVAL from 1 to 17 in handleBatchEvent to ensure events are spaced out by at least one frame. - Add detailed debug logs with original timestamps. - Fix lint errors (max-len) in mesh-service.js, scratch3_event.js, and runtime.js. Issue: scratchfoundation#473
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements batch event sending for Mesh v2 to reduce AWS AppSync Subscription costs and preserve event timing.
Key changes:
Related Issue: smalruby/smalruby3-gui#473