fix(mesh-v2): UI improvements and bug fixes (RSSI, disconnection) #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement calculateRssi method using 3000s max connection time constant. - Update scan() to calculate RSSI for discovered groups. - Add unit tests for calculateRssi. - Task (3) of issue scratchfoundation#471. Co-Authored-By: Gemini <noreply@google.com>
- Forward arguments for PERIPHERAL_CONNECTED/DISCONNECTED in VM. - Call cleanupAndDisconnect() early in leaveGroup(). - Pass extensionId when emitting DISCONNECTED. - Task (2) of issue scratchfoundation#471. Co-Authored-By: Gemini <noreply@google.com>
- Update RSSI calculation to use MESH_MAX_CONNECTION_TIME_SECONDS environment variable - Add test case for custom environment variable in calculateRssi - Default to 3000 seconds if environment variable is not set Co-Authored-By: Gemini <noreply@google.com>
- Add shouldDisconnectOnError helper to check for critical connection errors - Use GraphQL errorType (GroupNotFound, Unauthorized, NodeNotFound) for detection - Fallback to message string matching for backward compatibility - Ensure immediate disconnection on heartbeat, data, or event failure if connection is invalid - Add comprehensive unit tests for error handling logic Co-Authored-By: Gemini <noreply@google.com>
- Add client-side filtering for expired groups in scan() method - Ensure only groups with a valid future expiresAt are listed - Update unit test to verify expired group filtering Co-Authored-By: Gemini <noreply@google.com>
- Remove debug logs added for RSSI investigation - Keep expired group filtering log for troubleshooting - Clean up calculateRssi, createGroup, renewHeartbeat, and scan logs 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses tasks (2) and (3) of issue scratchfoundation#471.
Related issue: smalruby/smalruby3-gui#471