feat: Mesh V2 improvements (UI, event handler, production config) #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add MESH_ID_LABEL_CHARACTERS and makeMeshIdLabel() for user-friendly labels - Use labels in connection modal for both host and joining options - Use nodeId as initial group name for hosts - Update connectedMessage to show group name labels - Rename EXTENSION_NAME to 'Mesh V2' 🤖 Generated with [Gemini Code](https://gemini.google.com/code) Co-Authored-By: Gemini <noreply@google.com>
…shV2Service - Import BlockUtility in mesh-service.js - Update MeshV2Service constructor to accept blocks and hold runtime - Implement handleEvent() to integrate with Scratch broadcast system - Pass blocks reference when initializing MeshV2Service in index.js 🤖 Generated with [Gemini Code](https://gemini.google.com/code) Co-Authored-By: Gemini <noreply@google.com>
- Set production values for GraphQL endpoint, region and API key - Add optional maxConnectionTimeSeconds parameter to CREATE_GROUP mutation 🤖 Generated with [Gemini Code](https://gemini.google.com/code) Co-Authored-By: Gemini <noreply@google.com>
- Update joinGroup() to accept and set groupName - Pass group name from discoveredGroups when joining as peer - Make makeMeshIdLabel() robust against null/undefined IDs 🤖 Generated with [Gemini Code](https://gemini.google.com/code) Co-Authored-By: Gemini <noreply@google.com>
…gnature - Updated 'connect as host' to expect nodeId as group name - Updated 'connect as peer' to match new joinGroup signature including groupName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements several improvements for the Mesh V2 extension based on Issue scratchfoundation#469 in smalruby3-gui.
Key Changes
Improved Connection UI
MESH_ID_LABEL_CHARACTERSandmakeMeshIdLabel()to convert cryptic node/group IDs into user-friendly labels (e.g., "なにうとてに").nodeId.Event Handler Implementation
MeshV2Serviceto hold references toblocksandruntime.handleEvent()to integrate received Mesh events with the Scratch broadcast system usingevent_broadcast.BlockUtilityfor proper execution context.Extension Renaming
Production Configuration
mesh-client.jswith production AppSync endpoint, region, and API key.CREATE_GROUPmutation to support the optionalmaxConnectionTimeSecondsparameter.🤖 Generated with Gemini Code
Co-Authored-By: Gemini noreply@google.com