Update current sources while reading late sources#1467
Open
damianorenfer wants to merge 1 commit intosmallrye:mainfrom
Open
Update current sources while reading late sources#1467damianorenfer wants to merge 1 commit intosmallrye:mainfrom
damianorenfer wants to merge 1 commit intosmallrye:mainfrom
Conversation
damianorenfer
force-pushed
the
improve-late-souces-init
branch
from
ec38adb to
f35cade
Compare
Without this, a custom `ConfigSourceFactory` is not able to access properties defined in files referenced in `smallrye.config.locations`.
damianorenfer
force-pushed
the
improve-late-souces-init
branch
from
f35cade to
756ef8c
Compare
Member
|
Thank you for the PR. I'm not sure if we want to support this. The reason why we don't update late sources mid-read is that we don't know their order, so in the case you have multiple configurable sources, they don't contribute values to each other, because you may end up having different configuration values for the same key on each added source. Maybe we could explore initializing sources with |
Author
|
Sure, thanks for having a look. You know the lib better than me, I trust you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, a custom
ConfigSourceFactoryis not able to access properties defined in files referenced insmallrye.config.locations.