Makes EnvName mutable to avoid allocating it for lookups#1295
Open
franz1981 wants to merge 1 commit intosmallrye:mainfrom
Open
Makes EnvName mutable to avoid allocating it for lookups#1295franz1981 wants to merge 1 commit intosmallrye:mainfrom
franz1981 wants to merge 1 commit intosmallrye:mainfrom
Conversation
Contributor
Author
|
A similar effect with a smaller increment could be obtained via int[] cache of hash codes; we can still perform hash code computation directly on the String and using the int[] as a sort of bloom filter using a single hash function:
That depends by the collision of keys vs the given hash function, so the effect is potential reduction of allocations |
radcortez
reviewed
Feb 3, 2025
Comment on lines
+108
to
+119
| EnvName envName = reusableEnvName; | ||
| if (envName == null) { | ||
| envName = new EnvName(propertyName); | ||
| this.reusableEnvName = envName; | ||
| } else { | ||
| envName.setName(propertyName); | ||
| } | ||
| try { | ||
| return envVars.getEnv().containsKey(envName); | ||
| } finally { | ||
| envName.reset(); | ||
| } |
Member
There was a problem hiding this comment.
This can cause issues if not thread-safe. While we use a simple HashMap, we never modify it after creation.
Contributor
Author
There was a problem hiding this comment.
I can make #1295 (comment) once you apply your changes :P
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #1294 I've discovered two interesting things:
EnvName::hashCode(which is compute intensive) it's performed twice due to a mix of ifget == null,put: here I've enabled hashCode caching, despite it makesEnvNamea bit fatter i.e. 24 bytes vs 16 :"(EnvNameis created multiple times on the fly, to perform matching - without ever storing it (!). And most of the times these are misses: I've than allow it to be mutable to avoid keeping on allocating them