Skip to content

Pathology Report validators#37

Merged
aschroed merged 11 commits intomasterfrom
260226_ajs_path_report_validators
Mar 27, 2026
Merged

Pathology Report validators#37
aschroed merged 11 commits intomasterfrom
260226_ajs_path_report_validators

Conversation

@aschroed
Copy link
Copy Markdown
Contributor

Based on feedback from TPC - validators for non_brain and brain pathology report metadata have been added

Non-brain-path-reports:

  • target_tissues fields:
    • if present is:
    • No
      -ensures percentage == 0
      • autolysis score is not filled
    • Yes
      -ensures percentage is filled and not 0
      • autolysis score is filled
  • non-target tissue fields
    • if present is:
    • No percentage empty
    • Yes percentage filled
  • pathology_findings fields
    • if present is:
      • Yes
        • description is required
        • percentage is required
      • No
        • percentage is empty

Brain-path-reports:

  • brain-subregions - if present autolysis score is required
  • neuropathology-fields - if Yes decription is required
  • age related pathology fields - if Yes at least one must be filled

Also added an additional tissue_sample validator to make sure the category matches the expected external_id

Unit tests for all these.

@dbmi-svc-checkmarx
Copy link
Copy Markdown

dbmi-svc-checkmarx commented Mar 20, 2026

Logo
Checkmarx One – Scan Summary & Details9d12559f-7c3e-40e3-8d37-d38d50853ccd

Great job! No new security vulnerabilities introduced in this pull request


Use @Checkmarx to interact with Checkmarx PR Assistant.
Examples:
@Checkmarx how are you able to help me?
@Checkmarx rescan this PR

@aschroed aschroed merged commit b791616 into master Mar 27, 2026
6 checks passed
@aschroed aschroed deleted the 260226_ajs_path_report_validators branch March 27, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants