fix: dismiss camera on unmount and prevent duplicate scans#541
Open
dzlobin wants to merge 1 commit intoslopus:mainfrom
Open
fix: dismiss camera on unmount and prevent duplicate scans#541dzlobin wants to merge 1 commit intoslopus:mainfrom
dzlobin wants to merge 1 commit intoslopus:mainfrom
Conversation
…lopus#45) Camera stayed active on iOS after scanning a QR code because dismissScanner was only called inside the URL pattern check with no cleanup on effect unmount. Adds useRef guard to prevent duplicate scan processing, try/finally to ensure guard reset, and dismissScanner in useEffect cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useRefguard to prevent duplicate scan processing from rapid barcode eventstry/finallyso the guard resets even ifprocessAuthUrlthrowsuseConnectAccountanduseConnectTerminalhooksRoot Cause
dismissScanner()was only called inside the URL pattern check within the scan handler. If the component unmounted before or without a successful scan, the camera stayed active. Additionally, multiple barcode events could fire before the first finished processing.Closes #45
Test plan
🤖 Generated with Claude Code