fix: skip Ink rendering for daemon-spawned sessions#540
Open
dzlobin wants to merge 1 commit intoslopus:mainfrom
Open
fix: skip Ink rendering for daemon-spawned sessions#540dzlobin wants to merge 1 commit intoslopus:mainfrom
dzlobin wants to merge 1 commit intoslopus:mainfrom
Conversation
Daemon-spawned sessions have no human watching the terminal, so rendering Ink UI is unnecessary. This threads the startedBy field through Session and adds an explicit guard to skip Ink when startedBy === 'daemon', applied across Claude, Codex, and Gemini. Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
startedByfield through Session class so launchers know if a session was daemon-spawnedstartedBy !== 'daemon'guard tohasTTYchecks across Claude, Codex, and Gemini launchersContext
Daemon-spawned processes typically already have
process.stdout.isTTY === false, so the existinghasTTYcheck was already falsy. This adds a belt-and-suspenders explicit check for the case where a daemon process somehow has a TTY attached.Test plan
TTY available: undefined, startedBy: daemonfor daemon-spawned sessionsTTY available: true, startedBy: terminal🤖 Generated with Claude Code