fix: prevent tmux detach from stalling Happy CLI#539
Open
dzlobin wants to merge 1 commit intoslopus:mainfrom
Open
fix: prevent tmux detach from stalling Happy CLI#539dzlobin wants to merge 1 commit intoslopus:mainfrom
dzlobin wants to merge 1 commit intoslopus:mainfrom
Conversation
When tmux detaches, the PTY buffer fills and process.stdout.write() blocks synchronously, freezing the Node.js event loop. This wraps Ink's stdout in a non-blocking proxy that drops writes during backpressure instead of blocking. Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
When tmux detaches, the PTY buffer (~4KB on macOS) fills with no reader.
process.stdout.write()then blocks synchronously, freezing the entire Node.js event loop and stalling all Happy instances in that tmux session.Fix
A
Proxywrapsprocess.stdoutand interceptswrite()calls. WhenwritableNeedDrainis true orwrite()returns false, subsequent writes are silently dropped (with callbacks still invoked) until adrainevent fires. This is passed to Ink'srender()via thestdoutoption.Closes #533
Test plan
happyin tmux, detach, verify no stall, reattach and confirm UI resumes🤖 Generated with Claude Code