Skip to content

fix: create session sync client before metadata extraction #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vinhnxv wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: create session sync client before metadata extraction #156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/claude/runClaude.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,12 +162,15 @@ export async function runClaude(credentials: Credentials, options: StartOptions
logger.debug('[START] Failed to report to daemon (may not be running):', error);
}

// Create realtime session FIRST (before SDK metadata extraction)
const session = api.sessionSyncClient(response);

// Extract SDK metadata in background and update session when ready
extractSDKMetadataAsync(async (sdkMetadata) => {
logger.debug('[start] SDK metadata extracted, updating session:', sdkMetadata);
try {
// Update session metadata with tools and slash commands
api.sessionSyncClient(response).updateMetadata((currentMetadata) => ({
session.updateMetadata((currentMetadata) => ({
...currentMetadata,
tools: sdkMetadata.tools,
slashCommands: sdkMetadata.slashCommands
Expand All @@ -178,9 +181,6 @@ export async function runClaude(credentials: Credentials, options: StartOptions
}
});

// Create realtime session
const session = api.sessionSyncClient(response);

// Start Happy MCP server
const happyServer = await startHappyServer(session);
logger.debug(`[START] Happy MCP server started at ${happyServer.url}`);
Expand Down