Text: Add max-lines support and cap preferred height to visible line limit#10839
Open
amirHdev wants to merge 1 commit intoslint-ui:masterfrom
Open
Text: Add max-lines support and cap preferred height to visible line limit#10839amirHdev wants to merge 1 commit intoslint-ui:masterfrom
amirHdev wants to merge 1 commit intoslint-ui:masterfrom
Conversation
amirHdev
force-pushed
the
feat-text-max-lines-10799
branch
from
ce5dc5d to
dce83b3
Compare
- add max-lines property to text builtins and runtime items\n- cap text preferred vertical layout to configured line count\n- apply max-lines in software and parley text layout/rendering paths\n- add textlayout coverage for line-limiting behavior\n- compute line height from ascent/descent\n- use Coord typing for max-lines multiplication in int-coordinate builds Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
amirHdev
force-pushed
the
feat-text-max-lines-10799
branch
from
dce83b3 to
9c97b3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change adds support for limiting the number of visible lines in
Text/StyledTextvia a newmax-linesproperty.It also ensures layout sizing matches that behavior by capping preferred vertical size to the configured visible line limit.
Fixes #10799
Changes
max-linesto text builtins:SimpleText(inherited byComplexText)StyledTextItemmax_linesthroughRenderText.max-linesis set.TextParagraphLayout)Behavior
max-lines <= 0means no line limit.max-linesis set, rendering is limited to that many visible lines.Notes