Skip to content

Conversation

@chris-a-talbot
Copy link
Collaborator

Sorry, I started doing more thorough testing after I added the new providers (definitions, references, inlay hints, formatting, folding range) and the number of bug fixes/refactors got a little out of hand on this one. But it's working well, optimized, tested, and is now in a pretty comprehensive state, besides the biggest thing - comprehensive diagnostics - which is coming next (and will probably take a while).

…eferences, and definitions; general improvements all around; many new tests
@andrewkern
Copy link
Collaborator

this is looking great! i don't spot any issues on a pass through. i was using it a bit and seeing some weirdness with completions, i.e. some completions weren't working, but this might be my setup? do you notice intermittent completion failures?

@chris-a-talbot
Copy link
Collaborator Author

Any specific cases where completions aren't working? I've noticed one or two instances of completions mysteriously not working, which may be due to document caching. There were also some cases where completions might not be enabled at all - I also fixed this for loop variables, so e.g. subpop in a for (subpop in subpops) block will have completion enabled now. I also fixed potential issues with mutations - mutation types and instances weren't being properly differentiated, so hover info, completion, etc. wouldn't work on mutations in some cases. This update appears notably more consistent for me?

@andrewkern
Copy link
Collaborator

okay i just tried this out a bit and the fix you pushed seems to now work for me. I guess I was hitting race conditions? all seems to work now so I think this is ready to merge

@andrewkern andrewkern merged commit 8281fed into slim-community:main Dec 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants