-
Notifications
You must be signed in to change notification settings - Fork 1
v0.0.10 - Big improvements to instance track ing, hover info, documentation loading, and completion #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@chris-a-talbot -- any chance you could rebase this one before I review? looks like there are a bunch of already merged commits on this somehow e.g., f245a7e |
|
i.e. git fetch upstream
git rebase -i upstream/main |
de6bf11 to
71206a6
Compare
|
@andrewkern fixed it - not sure how it became such a mess but I'll try to keep it cleaner for the last few |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay @chris-a-talbot I went through this and it looks great overall. I did find one issue here with some commands note being registered and failing silently
|
one question here-- it looks to me like these commands will automatically open the doc pane when autocompletion is triggered -- is that the intent? |
…it tests, other small tweaks based on testing
|
Opening the docs every time definitely wasn't the intent, thanks for catching that - I didn't realize that was what that would be doing! I resolved that issue, and make some other adjustments with fresh post-Thanksgiving eyes and a bit more thorough testing. Let me know if there's anything else you catch from this update. |
|
This version is probably big enough to justify a new release on the GitHub too? I was planning to continue labeling future PRs 0.0.11, 0.0.12, etc., but could this feasibly be 0.1.0? |
|
okay @chris-a-talbot this looks good to go. I'm going to squash and merge. as for versioning-- maybe lets keep this at v0.0.10 and let's brainstorm on an issue about what a v0.1 release would look like? it would be great to do some thinking about what that would look like. |
This is a big one - added many new interdependent features.
Major Features
New Utilities
Services
Improvements to Existing Files
instance.ts
handlers.ts
hover.ts
extension.ts
Test Files