feat: Extend the package with unit test coverage functionality#87
Closed
TStanovcak wants to merge 5 commits intoslidoapp:mainfrom
Closed
feat: Extend the package with unit test coverage functionality#87TStanovcak wants to merge 5 commits intoslidoapp:mainfrom
TStanovcak wants to merge 5 commits intoslidoapp:mainfrom
Conversation
Collaborator
|
Hey @TStanovcak, apologies for a later reply. Thank you for the contribution, this is a nice addition to the package. I amended a few things and would like to update your PR and merge it. However, I can't seem to be able to push to your branch. Can you please check that you fulfil the criteria mentioned here? Most commonly the Allow edits from maintainers is disabled on the PR (docs). |
Collaborator
|
Thanks @TStanovcak, I moved the changes to #93 and merged it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces support for generating coverage reports for dbt unit tests using the dbt-coverage package. Until now, dbt-coverage focused exclusively on (data) test coverage. With this enhancement, users can also analyze coverage for dbt unit tests.
The approach should conform the original architecture by adding
unit_testoption tocomputecommand.Here's the example of the output:
As model can have more then 1 unit test, report is showing the count of the tests. If there's any, it translates into full percentage coverage.