-
-
Notifications
You must be signed in to change notification settings - Fork 41
Migrate to .NET 8 LTS, consolidate Docker infrastructure, and fix GitHub workflows #1365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: stefanb <319826+stefanb@users.noreply.github.com>
Please fix it and fix also all other workflows
Feel free to update the referenced action versions if needed. |
…kerfile Co-authored-by: stefanb <319826+stefanb@users.noreply.github.com>
Fixed both issues in commit 4fb38c8:
Additionally updated:
All YAML files validated successfully. |
|
@copilot, the workflow failed with:
Please update the dependancies as needed for upgraded node 20. |
Fixed Node.js 20 compatibility issue in commit fd6b29c by:
The build process now works with Node.js 20.11.1 as specified in the workflows. |
Co-authored-by: stefanb <319826+stefanb@users.noreply.github.com>
|
@copilot, the docker image build failed, likely because of outdated base image Please consolidate Running should succeed on amd64 or arm64 architecture, always using native Update also the devcontainer folder to the same versions. |
…s 20 Co-authored-by: stefanb <319826+stefanb@users.noreply.github.com>
Consolidated Docker infrastructure and updated devcontainer in commit 8abc560: Docker Consolidation:
DevContainer Updates:
The new |
This PR migrates all F# projects from .NET Core 3.0/3.1 to .NET 8 LTS, consolidates Docker infrastructure, and updates GitHub workflows to use supported runner images.
F# Projects Migration
Updated all F# projects to target .NET 8:
src/visualizations/App.fsprojfromnetcoreapp3.0tonet8.0tests/Visualizations.Tests/Visualizations.Tests.fsprojfromnetcoreapp3.1tonet8.0Owid.Analyzer/Owid.Analyzer.fsprojfromnetcoreapp3.1tonet8.0Docker Infrastructure Consolidation
Replaced the problematic two-Dockerfile setup with a single consolidated
Dockerfile:Before: Separate
base.Dockerfile(forghcr.io/sledilnik/website-base) +DockerfileAfter: Single
Dockerfilewith multi-stage buildThe new Docker setup:
node:20-alpine3.22base image with--platform=$BUILDPLATFORMfor native build performanceGitHub Workflows
Fixed deprecated actions and updated versions:
ubuntu-20.04toubuntu-22.04actions/cache@v3.3.1toactions/cache@v4actions/setup-nodeto v4 and other actions to latest versionsDevContainer Updates
Updated development environment to match production:
net8.0Package Compatibility
Fixed Node.js 20 compatibility issues:
@achrinza/node-ipc@10.1.11@vue/cli-plugin-babelto maintain Vue CLI v4 consistencyBenefits
The
docker build .command now works reliably on both amd64 and arm64 architectures without external image dependencies.Fixes #1364.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.