ex_syslogger has problems when part of a larger application with releases#1
Merged
slashmili merged 1 commit intoslashmili:masterfrom Sep 30, 2016
hazardfn:fix-application-for-releases
Merged
ex_syslogger has problems when part of a larger application with releases#1slashmili merged 1 commit intoslashmili:masterfrom hazardfn:fix-application-for-releases
slashmili merged 1 commit intoslashmili:masterfrom
hazardfn:fix-application-for-releases
Conversation
…sts in the logger backend, this way we only start syslog if we have a configured backend and it prevents it from being started twice which crashes applications
Owner
|
Pushed the changes to hex Thanks for fix 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When you add ex_syslogger as part of a larger application using a release manager like distillery/exrm :syslog can be started twice and depending on where you place :ex_syslogger in the list of applications/included_applications this can crash your application or cause a DRV_IN_USE error message which doesn't crash the app but is still an issue.
Solution
In this case I feel the :logger application should be responsible for starting :syslog as really they are only needed when you have an :ex_syslogger backend configured.
With this "code" change syslog is only started when you have a configured syslogger backend, it is started once by logger (in the init function).
EDIT
I noticed somebody over at the original project this was forked from posed a similar fix:
22cans/exsyslog#6